Skip to content

dep-info includes all transitvely linked files #23089

Closed

Description

@alexcrichton

I think that the changes in #22235 mean that the dep-info output includes too many files now:

$ touch foo.rs
$ rustc foo.rs --crate-type lib --emit=dep-info
$ cat foo.d

output

cc @michaelwoerister

Activity

  1. added a commit that references this issue on Mar 5, 2015
    9319252
  2. added a commit that references this issue on Mar 6, 2015
    0b7117b
  3. michaelwoerister commented on Mar 6, 2015

    @michaelwoerister
    Member

    Yes, driver::write_out_deps() probably needs to add a FileMap::is_imported() check to filter out files from other crates. I haven't had time to look into this in detail though.

    On March 5, 2015 11:38:23 PM CET, Alex Crichton notifications@github.com wrote:

    I think that the changes in #22235 mean that the dep-info output
    includes too many files now:

    $ touch foo.rs
    $ rustc foo.rs --crate-type lib --emit=dep-info
    $ cat foo.d
    

    output

    cc @michaelwoerister


    Reply to this email directly or view it on GitHub:
    #23089

    Sent from my Android device with K-9 Mail. Please excuse my brevity.

  4. alexcrichton commented on Mar 6, 2015

    @alexcrichton
    MemberAuthor

    No worries! I did precisely that in #23090 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions