Atomics docs should reference the C++11 standard instead of a GCC wiki page. #22064

Activity

1. steveklabnik commented on Feb 8, 2015

   

   steveklabnik

   on Feb 8, 2015

   Contributor

   More actions

   Why?
2. tomjakubowski commented on Feb 8, 2015

   

   tomjakubowski

   on Feb 8, 2015

   Contributor

   More actions

   Some reasons include:

   • The GCC wiki's content is transient and totally out of our control. Somebody could update the wiki with wrong information and mislead Rust documentation readers.
   • The text of the C++11 standard is guaranteed to have a correct description of C++11 atomics, by definition.
   • The pertinent sections of the standard can probably be quoted directly in our docs under fair use.
3. petrochenkov commented on Feb 8, 2015

   

   petrochenkov

   on Feb 8, 2015

   Contributor

   More actions

   Why 11 and not 14? With 14 our quotes will contain the latest editorial changes! :D
4. steveklabnik commented on Feb 8, 2015

   

   steveklabnik

   on Feb 8, 2015

   Contributor

   More actions

   Are either of those standards the definitive documentation for what we are doing? I'm not opposed to this, just trying to gain some more context here.
5. tomjakubowski commented on Feb 8, 2015

   

   tomjakubowski

   on Feb 8, 2015

   Contributor

   More actions

   I believe so. Rust uses LLVM's atomic intrinsic functions which correspond directly to C++11's atomic operations. See the LLVM language reference and a more informal description.

   If these descriptions aren’t precise enough, check [the Java and C++11] specs (see spec references in the atomics guide).
6. mahkoh commented on Feb 8, 2015

   

   mahkoh

   on Feb 8, 2015

   ContributorAuthor

   More actions

   Why?

   The GCC wiki is incomplete. I read it and then ten other websites that tried to provide an informal explanation of C++11 atomic operations before I looked at the standard itself and found a whole paragraph dedicated to my question.
7. steveklabnik

   added

   A-docs

   on Feb 9, 2015
8. steveklabnik

   added 4 commits that reference this issue on Feb 13, 2015

   Refer to LLVM rather than GCC wiki for atomic orderings

   ...

   This issue will close once commit 114301f is merged into the 'master' branch.

   114301f

   Rollup merge of rust-lang#22272 - steveklabnik:gh22064, r=alexcrichton

   ...

   This issue will close once commit b61d2bb is merged into the 'master' branch.

   b61d2bb

   Rollup merge of rust-lang#22272 - steveklabnik:gh22064, r=alexcrichton

   ...

   This issue will close once commit c242922 is merged into the 'master' branch.

   c242922
9. Manishearth

   added a commit that references this issue on Feb 15, 2015

   Rollup merge of rust-lang#22272 - steveklabnik:gh22064, r=alexcrichton

   ...

   This issue will close once commit 828a864 is merged into the 'master' branch.

   828a864
10. bors

    closed this as completedin #22272on Feb 16, 2015