Skip to content

Unify OS-specific types' trait implementations #20260

Closed

Description

@flaper87

There are quite few os-specific types definitions whose traits implementations are not consistent. With the work happening in OIBIT, I've tried to keep the implementations of built-in traits consistent for both unix and windows. Unfortunately, the test suite for these implementations is not unified, therefore there's a high chance that some types for window's implementation may have some traits implemented, whereas the unix's implementation doesn't.

In theory, we can assume that common types for these implementations should implement the same built-in types, therefore there should be tests that enforce this guarantee in a common place.

Some examples may be found in std::sys::{unix,windows}::{pipe,mutex}

This bug is to track the work there which impacts the stability of our standard library.

Activity

  1. added
    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
    on Dec 27, 2014
  2. flaper87 commented on Dec 27, 2014

    @flaper87
    ContributorAuthor

    I can mentor on this bug, tagging with E-mentor

  3. added
    E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
    on Dec 27, 2014
  4. druzn3k commented on Dec 27, 2014

    @druzn3k

    @flaper87 seems interesting. Can i take this bug? :)

  5. flaper87 commented on Dec 27, 2014

    @flaper87
    ContributorAuthor

    @druzn3k it's all yours, lemme know if you need help/reviews

  6. fables-tales commented on Feb 9, 2015

    @fables-tales
    Contributor

    This should be closed now right?

  7. flaper87 commented on Feb 10, 2015

    @flaper87
    ContributorAuthor

    @samphippen correct. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions