Skip to content

diagnostic::do_not_recommend can emit an error if it encounters a keyword #151996

Closed
#151999
Closed
diagnostic::do_not_recommend can emit an error if it encounters a keyword#151996
#151999
Assignees
mejrs
Labels
A-attributesArea: Attributes (`#[…]`, `#![…]`)C-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Description

@mejrs
mejrs
opened on Feb 2, 2026

I tried this code:

#![crate_type = "lib"]

pub trait X{}
pub struct Y;

#[diagnostic::do_not_recommend(if)]
impl X for Y {}

I expected to see this happen: a warning

Instead, this happened: an error

Meta

current nightly

this attribute is never allowed to error, this is a corner case I missed in #151516

cc @JonathanBrouwer @jdonszelmann

@rustbot claim

Activity

  1. mejrs
    added
    C-bugCategory: This is a bug.
    on Feb 2, 2026
  2. rustbot
    added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Feb 2, 2026
  3. rustbot
    assigned
    mejrs
    on Feb 2, 2026
  4. jieyouxu
    added
    A-attributesArea: Attributes (`#[…]`, `#![…]`)
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    and removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Feb 2, 2026

  5. Krishna-js45 commented on Feb 2, 2026

    @Krishna-js45
    Krishna-js45
    on Feb 2, 2026 · Hidden as spam
  6. JonathanBrouwer
    added a commit that references this issue on Feb 2, 2026

    Rollup merge of rust-lang#151999 - mejrs:ignore_nonmeta_v2, r=Jonatha…

    8e39986
  7. jhpratt
    added a commit that references this issue on Feb 3, 2026

    Rollup merge of rust-lang#151999 - mejrs:ignore_nonmeta_v2, r=Jonatha…

    cbebacd
  8. rust-bors
    closed this as completedin #151999on Feb 3, 2026
  9. rust-timer
    added a commit that references this issue on Feb 3, 2026

    Unrolled build for #151999

    63f1b91
  10. github-actions
    added 2 commits that reference this issue on Feb 4, 2026

    Rollup merge of #151999 - mejrs:ignore_nonmeta_v2, r=JonathanBrouwer

    18b0863

    Rollup merge of #151999 - mejrs:ignore_nonmeta_v2, r=JonathanBrouwer

    6f78400
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)C-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions