Skip to content

remove Region: Deref<Target = RegionKind> impl #139359

Closed
#139509
Closed
remove Region: Deref<Target = RegionKind> impl#139359
#139509
Assignees
xizheyin
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-help-wantedCall for participation: Help is requested to fix this issue.E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-typesRelevant to the types team, which will review and decide on the PR/issue.

Description

@lcnr
lcnr
opened on Apr 4, 2025

call .kind() in cases where it is currently used.

This impl is a relic of back when we still interned regions as &'tcx RegionKind and differs from Ty and ty::Const

Activity

  1. lcnr
    added
    E-help-wantedCall for participation: Help is requested to fix this issue.
    E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.
    on Apr 4, 2025
  2. rustbot
    added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Apr 4, 2025
  3. lcnr
    added
    C-cleanupCategory: PRs that clean code up or issues documenting cleanup.
    on Apr 4, 2025

  4. xizheyin commented on Apr 7, 2025

    @xizheyin
    xizheyin
    on Apr 7, 2025
    Member

    How difficult is it to do this? I would love to do this.

  5. lcnr commented on Apr 7, 2025

    @lcnr
    lcnr
    on Apr 7, 2025
    ContributorAuthor

    Some familiarity with the compiler helps, but it should be doable.

  6. xizheyin commented on Apr 7, 2025

    @xizheyin
    xizheyin
    on Apr 7, 2025
    Member

    I can try and may need some advice if necessary.

    @rustbot claim

  7. rustbot
    assigned
    xizheyin
    on Apr 7, 2025
  8. matthiaskrgr
    added a commit that references this issue on Apr 8, 2025

    Rollup merge of rust-lang#139509 - xizheyin:issue-139359, r=lcnr

    1cbf8b5
  9. bors
    closed this as completedin 1cbf8b5on Apr 9, 2025
  10. rust-timer
    added a commit that references this issue on Apr 9, 2025

    Unrolled build for rust-lang#139509

    9ecbcfe
  11. jieyouxu
    added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    T-typesRelevant to the types team, which will review and decide on the PR/issue.
    and removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

C-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-help-wantedCall for participation: Help is requested to fix this issue.E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-typesRelevant to the types team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions