Skip to content

Move "miscellaneous language-construct benchmarks" out of core::mem #13642

Closed

Description

@aochagavia

In std::mem there are some benchmarks regarding to miscellaneous language constructs (such as pattern matching and method dispatch). Since they have nothing to do with memory and the functions defined in this file, I think they should be moved to another place.

I thought it was reasonable to move them to src/test/bench, but it looks like this is not very convenient (see #13553 (comment)).

Activity

  1. added a commit that references this issue on Apr 20, 2014
  2. changed the title [-]Move "miscellaneous language-construct benchmarks" out from std::mem[/-] [+]Move "miscellaneous language-construct benchmarks" out of std::mem[/+] on May 12, 2014
  3. aochagavia commented on Nov 24, 2014

    @aochagavia
    ContributorAuthor

    This has alredy been done

  4. changed the title [-]Move "miscellaneous language-construct benchmarks" out of std::mem[/-] [+]Move "miscellaneous language-construct benchmarks" out of core::mem[/+] on Oct 3, 2017
  5. reopened this on Oct 3, 2017
  6. dtolnay commented on Oct 3, 2017

    @dtolnay
    Member

    Reopening because I don't think this was ever finished. The benchmarks were moved from std to core and from src to benches, but as of Rust 1.20 they are in libcore/benches/mem.rs which is still confusing because as commented above, they have nothing to do with memory or the functions in core::mem.

  7. added
    C-enhancementCategory: An issue proposing an enhancement or a PR with one.
    T-libs-api[DEPRECATED; DO NOT USE]
    on Jan 21, 2018
  8. Mark-Simulacrum commented on Dec 7, 2019

    @Mark-Simulacrum
    Member

    It looks like #44943 did indeed move the benchmarks out of libcore (and into librustc), so closing this.

  9. added a commit that references this issue on Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-enhancementCategory: An issue proposing an enhancement or a PR with one.T-libs-api[DEPRECATED; DO NOT USE]

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions