Skip to content

Add tests for checking the glibc version required by rustc #134037

Closed
#135164
Closed
Add tests for checking the glibc version required by rustc#134037
#135164
Assignees
Kobzol
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcC-enhancementCategory: An issue proposing an enhancement or a PR with one.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Description

@Kobzol
Kobzol
opened on Dec 8, 2024

We promise that our GNU rustc toolchains won't need a glibc newer than a certain version (https://blog.rust-lang.org/2022/08/01/Increasing-glibc-kernel-requirements.html), but we don't currently have a test that would actually test this. It can be quite easy to inadvertedly bump the glibc, for example when updating base images of the OS in a container that builds the dist toolchain on CI.

It would be nice of we had some kind of (run-make?) test that checks the exact version of glibc used by a toolchain compiled on CI. It should be executed explicitly in specific CI runners, so that we can vary the required glibc version per CI job (and thus per tier/platform).

Activity

  1. Kobzol
    added
    A-testsuiteArea: The testsuite used to check the correctness of rustc
    on Dec 8, 2024
  2. rustbot
    added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Dec 8, 2024
  3. jieyouxu
    added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
    C-enhancementCategory: An issue proposing an enhancement or a PR with one.
    and removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Dec 9, 2024
  4. onur-ozkan
    added
    T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.
    on Dec 9, 2024
  5. Kobzol
    self-assigned this
    on Jan 6, 2025
  6. bors
    added 8 commits that reference this issue on Jan 20, 2025

    Auto merge of rust-lang#135164 - Kobzol:run-make-test-glibc-symbols, …

    52402df

    Auto merge of rust-lang#135164 - Kobzol:run-make-test-glibc-symbols, …

    b746d2f

    Auto merge of rust-lang#135164 - Kobzol:run-make-test-glibc-symbols, …

    63cdc3c

    Auto merge of rust-lang#135164 - Kobzol:run-make-test-glibc-symbols, …

    0d87e15

    Auto merge of rust-lang#135164 - Kobzol:run-make-test-glibc-symbols, …

    694e488

    Auto merge of rust-lang#135164 - Kobzol:run-make-test-glibc-symbols, …

    a3df310

    Auto merge of rust-lang#135164 - Kobzol:run-make-test-glibc-symbols, …

    61f78e2

    Auto merge of rust-lang#135164 - Kobzol:run-make-test-glibc-symbols, …

    3cd8fcb
  7. bors
    closed this as completedin 3cd8fcbon Jan 23, 2025
  8. github-actions
    added 2 commits that reference this issue on Jan 23, 2025

    Auto merge of #135164 - Kobzol:run-make-test-glibc-symbols, r=jieyouxu

    2c60bb2

    Auto merge of #135164 - Kobzol:run-make-test-glibc-symbols, r=jieyouxu

    023a2a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcC-enhancementCategory: An issue proposing an enhancement or a PR with one.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions