Skip to content

tests/assembly/x86_64-bigint-add.rs broken with LLVM 20 #133754

Closed
#135764
Closed
tests/assembly/x86_64-bigint-add.rs broken with LLVM 20#133754
#135764
Assignees
nikic
Labels
A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Description

@krasimirgg
krasimirgg
opened on Dec 2, 2024

It looks like tests/assembly/x86_64-bigint-add.rs broken, newly added in 9836196, produces slightly different assembly with LLVM-at-HEAD:

https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/33017#01938775-555b-4915-9c10-08f40d14cdad/945-946

@scottmcm: does the new assembly produced look good? Happy to adapt the test for this.

cc: @scottmcm @durin42

Activity

  1. krasimirgg
    added
    C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFC
    on Dec 2, 2024

  2. krasimirgg commented on Dec 2, 2024

    @krasimirgg
    krasimirgg
    on Dec 2, 2024
    ContributorAuthor

    @rustbot label +A-LLVM

  3. rustbot
    added
    A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
    on Dec 2, 2024
  4. jieyouxu
    added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    C-bugCategory: This is a bug.
    A-testsuiteArea: The testsuite used to check the correctness of rustc
    and removed
    C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFC
    on Dec 2, 2024
  5. nikic
    self-assigned this
    on Jan 20, 2025

  6. nikic commented on Jan 20, 2025

    @nikic
    nikic
    on Jan 20, 2025
    Contributor

    It looks like this is just a difference in unroll factor: https://www.diffchecker.com/qUdwbutN/ LLVM 20 unrolls this loop less aggressively.

  7. jhpratt
    added a commit that references this issue on Jan 23, 2025

    Rollup merge of rust-lang#135764 - nikic:llvm-20-test-fixes, r=wesley…

    0e05362
  8. matthiaskrgr
    added 3 commits that reference this issue on Jan 25, 2025

    Rollup merge of rust-lang#135764 - nikic:llvm-20-test-fixes, r=wesley…

    c8f74eb

    Rollup merge of rust-lang#135764 - nikic:llvm-20-test-fixes, r=wesley…

    59ac9a5

    Rollup merge of rust-lang#135764 - nikic:llvm-20-test-fixes, r=wesley…

    d49be9b
  9. jhpratt
    added a commit that references this issue on Jan 26, 2025

    Rollup merge of rust-lang#135764 - nikic:llvm-20-test-fixes, r=wesley…

    3476bb2
  10. bors
    added a commit that references this issue on Jan 26, 2025

    Auto merge of rust-lang#135764 - nikic:llvm-20-test-fixes, r=wesleywiser

    01a26c0
  11. bors
    closed this as completedin 01a26c0on Jan 26, 2025
  12. github-actions
    added a commit that references this issue on Jan 27, 2025

    Auto merge of #135764 - nikic:llvm-20-test-fixes, r=wesleywiser

    5d6f825
  13. RalfJung
    added a commit that references this issue on Jan 28, 2025

    Auto merge of #135764 - nikic:llvm-20-test-fixes, r=wesleywiser

    87c50e9
  14. github-merge-queue
    added a commit that references this issue on Feb 10, 2025

    Auto merge of #135764 - nikic:llvm-20-test-fixes, r=wesleywiser

    3c9f396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions