make; sudo make install leaves files owned by root #13190

Activity

1. thestinger commented on Mar 29, 2014

   

   thestinger

   on Mar 29, 2014

   Contributor

   More actions

   It's best to run make install as non-root with DESTDIR and then install that globally - ideally with a package manager, but with cp -a if you must. This issue can be fixed, but the Makefile is a scary beast and this issue will keep coming back. I wouldn't trust it to be run as root, since one typo is enough to wipe the system out.

   MrMEEE/bumblebee-Old-and-abbandoned@a047be8
2. brson

   self-assigned this

   on Mar 29, 2014
3. tedhorst commented on Mar 29, 2014

   

   tedhorst

   on Mar 29, 2014

   ContributorAuthor

   More actions

   Yes, that would be much safer. Will there be any issues with embedded paths?
4. thestinger commented on Mar 29, 2014

   

   thestinger

   on Mar 29, 2014

   Contributor

   More actions

   There are embedded runpaths but the ones that will be incorrect with this intermediate step are still incorrect without it. I recommend compiling with ./configure --disable-rpath if you want to install globally, as they're not required unless you're running out of the build directory. A rustc compiled with --disable-rpath will still use runpaths for the binaries it compiles, so it won't break anything.
5. brson

   added a commit that references this issue on Mar 31, 2014

   mk: Don't touch config.tmp or tmp/dist as root. Closes rust-lang#13190

   ...

   This issue will close once commit cfb52a5 is merged into the 'master' branch.

   cfb52a5
6. brson

   closed this as completedin cfb52a5on Mar 31, 2014