Skip to content

x.py test mir-opt --bless does not bless some tests #122292

Description

@RalfJung

To reproduce, simply edit the file tests/mir-opt/pre-codegen/checked_ops.checked_shl.PreCodegen.after.mir and then run x.py test mir-opt --bless. I'd expect the file to be changed back, but actually it is left unchanged.

Interestingly, x.py test mir-opt does check that file. This is on a x86-64 host, and the test is marked needs-unwind and only-x86_64. --bless adds a bunch of extra targets to bless, seems like my default target x86_64 with unwinding is not one of them though?

--bless should make sure to always bless the configuration that is tested without --bless.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions