Skip to content

stage0 run-make compiletest broken  #122196

Closed
#122248
Closed
stage0 run-make compiletest broken #122196
#122248
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Description

@bjorn3
bjorn3
opened on Mar 8, 2024

COMPILETEST_FORCE_STAGE0=1 ./x.py test --stage 0 tests/run-make no longer works. librun_make_support.rlib is compiled using the bootstrap rustc wrapper which sets --sysroot build/$HOST_TRIPLE/stage0-sysroot, but then compiletest will compile rmake.rs using the sysroot of the bootstrap compiler causing it to not find the libstd.rlib against which librun_make_support.rlib is compiled.

This regressed with #113026. (cc @jieyouxu)

Activity

  1. bjorn3
    added
    C-bugCategory: This is a bug.
    on Mar 8, 2024
  2. rustbot
    added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Mar 8, 2024

  3. bjorn3 commented on Mar 8, 2024

    @bjorn3
    bjorn3
    on Mar 8, 2024
    MemberAuthor

    See also https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/stage0.20compiletest.20broken

  4. jieyouxu commented on Mar 8, 2024

    @jieyouxu
    jieyouxu
    on Mar 8, 2024
    Member

    From the zulip comment

    Pass the right --sysroot when compiling rmake.rs, use the bootstrap rustc wrapper in compiletest too? Or something else?

    Passing the right --sysroot might be the least disruptive solution (would anything wonky happen if we use bootstrap rustc wrapper in compiletest too?), but I'm not sure if this is the best solution.

  5. jieyouxu
    added
    A-testsuiteArea: The testsuite used to check the correctness of rustc
    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
    and removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Mar 8, 2024
  6. matthiaskrgr
    added 2 commits that reference this issue on Mar 17, 2024

    Rollup merge of rust-lang#122248 - jieyouxu:rmake-sysroot, r=Mark-Sim…

    86bf51e

    Rollup merge of rust-lang#122248 - jieyouxu:rmake-sysroot, r=Mark-Sim…

    a5dbdc2
  7. bors
    closed this as completedin a5dbdc2on Mar 17, 2024
  8. rust-timer
    added a commit that references this issue on Mar 17, 2024

    Unrolled build for rust-lang#122248

    3fb7e4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions