invalid_from_utf8_unchecked does not fail for include_bytes!

This code should fail if invalid.txt contains invalid UTF-8.

let str = include_bytes!("../invalid.txt");
let str = unsafe { std::str::from_utf8_unchecked(str) };

This should fail as the byte sequence is known at compile time!

Isn't this the purpose of include_str!() ? I think Clippy should deny include_bytes!() on text files, as str::as_bytes() is a no-op.

Isn't this the purpose of include_str!()?

That's not the point. A literal sequence of bytes known at compile time should fail if invalid utf8 is found, no matter how it's loaded.

I think Clippy should deny include_bytes!() on text files, as str::as_bytes() is a no-op.

What's a text file? How can you tell it apart from any other file?

Rollup merge of rust-lang#115257 - Urgau:invalid-utf8-walk-up-hir, r=…

Navigation Menu