Check Rustdoc warnings for the compiler in PR CI #106624

Activity

1. Noratrieb

   added

   C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.

   T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.Relevant to the infrastructure team, which will review and decide on the PR/issue.

   on Jan 9, 2023
2. Noratrieb

   changed the title [-]Check docs CI[/-] [+]Check docs in CI[/+] on Jan 9, 2023
3. albertlarsan68 commented on Jan 9, 2023

   

   albertlarsan68

   on Jan 9, 2023

   Member

   More actions

   @rustbot claim
4. rustbot

   assigned

   albertlarsan68

   on Jan 9, 2023
5. the8472 commented on Jan 9, 2023

   

   the8472

   on Jan 9, 2023

   Member

   More actions

   But ./x test linkchecker already runs in PR CI

   👍React with 👍2Reacted by León Orell Valerian Liehr and jyn
6. jyn514 commented on Jan 10, 2023

   

   jyn514

   on Jan 10, 2023

   Member

   More actions

   cc #106117

   maybe linkchecker is missing some cases?
7. Noratrieb commented on Jan 10, 2023

   

   Noratrieb

   on Jan 10, 2023

   MemberAuthor

   More actions

   The most recent case I've seen was this: #100036 (comment)
   where broken docs broke a try build while PR CI was green (that wasn't an intra doc link though but still docs)
8. jyn514 commented on Jan 10, 2023

   

   jyn514

   on Jan 10, 2023

   Member

   More actions

   Ah ok, this is specifically about rustdoc warnings, not broken links. That's definitely doable to do, we can shove x doc --stage 0 compiler into mingw-check :) it doesn't need to build the compiler at all, only check it.
9. jyn514

   added

   A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustc

   E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

   E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.Call for participation: Medium difficulty. Experience needed to fix: Intermediate.

   on Jan 10, 2023
10. jyn514

    changed the title [-]Check docs in CI[/-] [+]Check Rustdoc warnings for the compiler in PR CI[/+] on Jan 10, 2023
11. lukas-code commented on Jan 11, 2023

    

    lukas-code

    on Jan 11, 2023

    Contributor

    More actions

    But ./x test linkchecker already runs in PR CI

    Apparently ./x test linkchecker doesn't actually build the compiler docs (or tool docs) when the build.compiler-docs flag isn't set in config.toml. I don't know if this is a bug or a feature, but we could just set the flag for CI here:
    

    rust/src/ci/docker/host-x86_64/x86_64-gnu-llvm-13/Dockerfile

    Lines 45 to 49 in 002eccc

    	ENV RUST_CONFIGURE_ARGS \
    	--build=x86_64-unknown-linux-gnu \
    	--llvm-root=/usr/lib/llvm-13 \
    	--enable-llvm-link-shared \
    	--set rust.thin-lto-import-instr-limit=10
12. lukas-code commented on Jan 11, 2023

    

    lukas-code

    on Jan 11, 2023 · Hidden as duplicate

    show commentMore actions
13. JohnTitor

    added a commit that references this issue on Jan 14, 2023

    Rollup merge of rust-lang#106670 - albertlarsan68:check-docs-in-pr-ci…

    ...

    This issue will close once commit 233169f is merged into the 'main' branch.

    233169f
14. bors

    closed this as completedin 233169fon Jan 14, 2023