MSI installer is missing clippy and rustfmt

I installed Rust 1.63.0 in Windows via the MSI installer. I enabled all optional features during the installation process. However, it seems that clippy and rustfmt are not available via the MSI installer. It seems that the MSI installer is oriented at development use and not just building existing Rust code from source for deployment (otherwise it wouldn’t include RLS, which is only useful for development), so there ought to be a way to get access to clippy and rustfmt through it—and one can’t just cargo install them, at least not clippy, because cargo install clippy reports that clippy is no longer available via crates.io.

Sorry if this is the wrong repo to report MSI installer issues; with 190 repos in the group, it can be hard to find the right one.

Hmm, there's code for clippy in dist.rs - not sure what's going wrong there, someone would need to investigate.

rust/src/bootstrap/dist.rs

Lines 1617 to 1633 in ed37111

    
           builder.run( 
        
               Command::new(&heat) 
        
                   .current_dir(&exe) 
        
                   .arg("dir") 
        
                   .arg("clippy") 
        
                   .args(&heat_flags) 
        
                   .arg("-cg") 
        
                   .arg("ClippyGroup") 
        
                   .arg("-dr") 
        
                   .arg("Clippy") 
        
                   .arg("-var") 
        
                   .arg("var.ClippyDir") 
        
                   .arg("-out") 
        
                   .arg(exe.join("ClippyGroup.wxs")) 
        
                   .arg("-t") 
        
                   .arg(etc.join("msi/remove-duplicates.xsl")), 
        
           );

Rustfmt does appear to just be omitted altogether, that should be a simple fix.

I see rustfmt is not called with prepare, but clippy is there:

            prepare("clippy");
            for tool in &["rust-demangler", "rust-analyzer", "miri"] {
                if built_tools.contains(tool) {
                    prepare(tool);
                }
            }
            if target.ends_with("windows-gnu") {
                prepare("rust-mingw");
            }

have a diff from cargo --list between rustup from installation and MSI installer:

9d8
<     clippy               Checks a package to catch common mistakes and improve your Rust code.
15d13
<     fmt                  Formats all bin and lib files of the current crate using rustfmt.
25d22
<     miri
46a44
>

seems miri also missing.

Here’s a list of the files in the bin/ subdirectory of my install directory, in case it’s relevant:

cargo.exe
rls.exe
rustc_driver-17b2400b2defcd83.dll
rustc_driver-17b2400b2defcd83.pdb
rustc.exe
rustc_main-6addbff947989b19.pdb
rustdoc.exe
rust-windbg.cmd
std-2e5a4fde2066d4f2.dll
std-2e5a4fde2066d4f2.pdb
test-2fc9b45aeebba85a.dll
test-2fc9b45aeebba85a.pdb

@rustbot

@rustbot claim

Rollup merge of rust-lang#131365 - heiseish:fix-issue-101993, r=Mark-…

Auto merge of rust-lang#131970 - matthiaskrgr:rollup-nr32ksd, r=matth…

Unrolled build for rust-lang#131365

Navigation Menu

Repository navigation

MSI installer is missing clippy and rustfmt #101993

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	builder.run(
	Command::new(&heat)
	.current_dir(&exe)
	.arg("dir")
	.arg("clippy")
	.args(&heat_flags)
	.arg("-cg")
	.arg("ClippyGroup")
	.arg("-dr")
	.arg("Clippy")
	.arg("-var")
	.arg("var.ClippyDir")
	.arg("-out")
	.arg(exe.join("ClippyGroup.wxs"))
	.arg("-t")
	.arg(etc.join("msi/remove-duplicates.xsl")),
	);

MSI installer is missing clippy and rustfmt #101993

Description

Activity

jyn514 commented on Sep 18, 2022

chenyukang commented on Sep 20, 2022

chenyukang commented on Sep 20, 2022

Hawk777 commented on Sep 20, 2022

heiseish commented on Sep 27, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions