Skip to content

fail_bounds_check in unstable.rs should return ! #10023

Closed

Description

@alexcrichton

This tells LLVM that the function returns, and will hopefully help codegen to place the failing bounds check function calls at the end of the codegen'd function instead of inline with the rest of the code.

It would also be great to have a before/after analysis of some bounds checks to see if this improves codegen at all.

Activity

  1. thestinger commented on Oct 23, 2013

    @thestinger
    Contributor

    I also have a branch adding support for a #[cold] attribute but I haven't actually investigated whether it helps yet... :)

  2. added a commit that references this issue on Oct 24, 2013
    7075eb3
  3. added a commit that references this issue on Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-codegenArea: Code generationE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions