Repository navigation
Add new lint obfuscated_if_else - #9148
Merged
Merged
Conversation
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
|
Just going to nitpick the name here. Basically the same lint applies to any combinations of [ |
Contributor
Author
|
I was trying to follow the naming guidelines of stating the thing that is wrong. What do you think about |
Contributor
|
I think |
New lint suggests using `if .. else ..` instead of `.then_some(..).unwrap_or(..)`.
arieluy
force-pushed
the
then_some_unwrap_or
branch
from
July 18, 2022 01:49
ee5e1da to
9ff7c91
Compare
arieluy
changed the title
then_some_unwrap_orobfuscated_if_else
Contributor
|
Looks good. Thank you. @bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This was referenced Jul 18, 2022
Merged
Contributor
Author
|
Thanks @Jarcho ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #9100, additional commits could make it work with
thenandunwrap_or_elseas wellchangelog: Add new lint
obfuscated_if_else