Conversation
rustbot
added
needs-fcp
Collaborator
|
r? @llogiq rustbot has assigned @llogiq. Use Why was this reviewer chosen?The reviewer was selected based on:
|
llogiq
enabled auto-merge
June 11, 2026 10:54
|
Lintcheck changes for ab9ee11
This comment will be updated if you push new changes |
rustbot
removed
the
S-waiting-on-review
epage
added a commit
to epage/_rust
that referenced
this pull request
Aug 9, 2026
`clippy::from_iter_instead_of_collect` was [deprecated](rust-lang/rust-clippy#17208) a couple of months ago, and shows a warning on `beta` (`1.98.0`) when there is any config set for it: ``` warning: lint `clippy::from_iter_instead_of_collect` has been removed: lint has proved problematic | = note: requested on the command line with `-W clippy::from_iter_instead_of_collect` = note: `#[warn(renamed_and_removed_lints)]` on by default ``` Given that `1.98.0` will be `stable` in a couple of weeks (`2026-08-20`), I figured it would be a good idea to remove `from_iter_instead_of_collect` from `[lints.clippy]` early.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in
https://rust-lang.zulipchat.com/#narrow/channel/559984-clippy.2Fmeetings/topic/Meeting.202026-06-09/with/601758524
changelog: [
from_iter_instead_of_collect]: deprecate lint which has proved to be problematic for very little gain