Repository navigation
Add spans to clippy.toml error messages - #10607
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @giraffate (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
the
S-waiting-on-review
3449295 to
11ed4ac
Compare
|
☔ The latest upstream changes (presumably #10751) made this pull request unmergeable. Please resolve the merge conflicts. |
9fb8f08 to
26e1ec5
Compare
giraffate
left a comment
giraffate
left a comment
There was a problem hiding this comment.
Sorry for the late reviewing. Overall looks good, thanks! I made one comment.
|
|
||
| #[derive(Debug)] | ||
| struct ConfError(String); | ||
| pub struct ConfError(pub String, pub Option<Span>); |
There was a problem hiding this comment.
IMO it would be easy to understand when accessing fields if its field has name, like error.message and error.span.
| pub struct ConfError(pub String, pub Option<Span>); | |
| pub struct ConfError { | |
| pub message: String, | |
| pub span: Option<Span>, | |
| } |
|
@bors r+ Thanks! |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Adds spans to errors and warnings encountered when parsing
clippy.toml.changelog: Errors and warnings generated when parsing
clippy.tomlnow point to the location in the TOML file the error/warning occurred.