Prototype validators API #27

Activity

1. matklad

   added

   E-hard

   on Jan 28, 2018
2. aochagavia commented on Oct 25, 2018

   

   aochagavia

   on Oct 25, 2018

   Contributor

   More actions

   Is there anything like this already in place? I am asking because the issue is old and sometimes changes are introduced without referring to the issue.
3. matklad commented on Oct 30, 2018

   

   matklad

   on Oct 30, 2018

   ContributorAuthor

   More actions

   Nothing is done yet, though we still need to implement this API.

   We have error method here, which returns a Vec<SyntaxError> precisely to allow to compute errors on the fly:

   https://github.com/rust-analyzer/rust-analyzer/blob/bc4de7128f474f75a9eff6591923657025099b74/crates/ra_syntax/src/lib.rs#L98

   So, what we need is to add a private fn validate(file: &File) -> Vec<SyntaxError> method, and append its results to the errors from the parser.

   Here is the subset of things which should be checked by validate:

   • string and char literals have closing quote
   • char literals are one symbol long
   • /* comments have a closing */
   • escapes in strings are valid
   • doc comments are attached to nodes Should DOC_COMMENT be removed? #166
4. bors

   added a commit that references this issue on Nov 4, 2018

   Merge #184

   ...

   576b9a0
5. aochagavia commented on Nov 9, 2018

   

   aochagavia

   on Nov 9, 2018

   Contributor

   More actions

   Superseded by #223
6. aochagavia

   closed this as completedon Nov 9, 2018
7. bors

   added a commit that references this issue on Nov 10, 2018

   Merge #222

   ...

   This issue will close once commit 477de79 is merged into the 'master' branch.

   477de79
8. lnicola

   added a commit that references this issue on Apr 7, 2024

   Auto merge of #118488 - andjo403:remove_deadlock, r=SparrowLii

   ...

   dab51a1
9. RalfJung

   added a commit that references this issue on Apr 27, 2024

   Auto merge of #118488 - andjo403:remove_deadlock, r=SparrowLii

   ...

   1c20e9a
10. Veykril

    added 2 commits that reference this issue on Nov 7, 2025

    Merge rust-lang#27

    ...

    496bf95

    Merge pull request rust-lang#27 from CAD97/ci-docs

    ...

    a399ea6