Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Update racer, rustfmt and clippy - #1313

Merged
bors merged 1 commit into
rust-lang:masterfrom
kngwyu:update-deps
Feb 14, 2019
Merged

bors merged 1 commit into
rust-lang:masterfrom
kngwyu:update-deps

Conversation

@kngwyu

@kngwyu kngwyu commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@kngwyu kngwyu changed the title Update racer, rustfmt, clippy Update racer, rustfmt and clippy Feb 14, 2019
@Xanewok

Xanewok commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

📌 Commit c78c953 has been approved by Xanewok

@bors

bors commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit c78c953 with merge 7cd58a4...

bors added a commit that referenced this pull request Feb 14, 2019
Update racer, rustfmt and clippy
@bors

bors commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

💔 Test failed - checks-travis

@Xanewok

Xanewok commented Feb 14, 2019 via email

Copy link
Copy Markdown
Contributor

@bors

bors commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors

bors commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

📌 Commit c78c953 has been approved by Xanewok

@bors

bors commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit c78c953 with merge 9d917fe...

bors added a commit that referenced this pull request Feb 14, 2019
Update racer, rustfmt and clippy
@Xanewok

Xanewok commented Feb 14, 2019 via email

Copy link
Copy Markdown
Contributor

@bors

bors commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

💡 This pull request was already approved, no need to approve it again.

  • This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.

@bors

bors commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

📌 Commit c78c953 has been approved by Xanewok

@bors

bors commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit c78c953 with merge 0d6f53e...

bors added a commit that referenced this pull request Feb 14, 2019
Update racer, rustfmt and clippy
@bors

bors commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-travis
Approved by: Xanewok
Pushing 0d6f53e to master...

@bors
bors merged commit c78c953 into rust-lang:master Feb 14, 2019
@jens1o

jens1o commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

Will this make it possible that rls will be in the next nightly cycle again?

@Xanewok

Xanewok commented Feb 14, 2019 via email

Copy link
Copy Markdown
Contributor

@mati865

mati865 commented Feb 14, 2019

Copy link
Copy Markdown
Member

Many people don't fully understand how it works.
Rust doesn't care about Clippy and Rustfmt versions in RLS repository because it patches RLS to use version that is checked at /src/tools/{clippy,rustfmt}.

So changes to them are not necessary to unblock tools for nightly. However it fixes stand-alone builds of RLS.

Racer update on the other hand is necessary because it syncs rustc-ap-syntax version to match other packages.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants