This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Repository navigation
Add rust-toolstate shields to README.md - #1023
Merged
Merged
Conversation
Contributor
|
Cool! Maybe we should link straight to https://rust-lang-nursery.github.io/rust-toolstate/ instead of the github project? |
Member
|
@Xanewok Interesting! Since you mentioned this depends on jsonpath, the following expression should work? |
Contributor
Author
|
Definitely! Thank you, pushed commits with respective changes. |
Contributor
Author
|
Seems to be working, now the shields are |
Member
|
This is so cool; great idea! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses awesome dynamic shields from https://shields.io and queries https://raw.githubusercontent.com/rust-lang-nursery/rust-toolstate/master/_data/latest.json tracked by our awesome rust-toolstate bot.
Rendered
The queries are currently
$[2].windowsand$[2].linux(jsonpath) respectively, because the data is an array of objects and RLS tool currently happens to be the 3rd one on the list.@kennytm hopefully this info in README.md shouldn't be useful for too long (because we might want to block nightlies again on RLS fail etc.) but do you think it might be a good idea to change the data format to an object with tool keys
{ "rls": {...}, "clippy": {...}, ... }to facilitate the quering (e.g.$.rls.linux) or do you think it's not worth the hassle?Doesn't seem we can dynamically set the color via the dynamic JSON badge, so I hardcoded the color to grey.
@nrc @jonathandturner @alexheretic
do you think this might be useful?