Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Add rust-toolstate shields to README.md - #1023

Merged
nrc merged 3 commits into
rust-lang:masterfrom
Xanewok:nightly-shields
Aug 30, 2018
Merged

nrc merged 3 commits into
rust-lang:masterfrom
Xanewok:nightly-shields

Conversation

@Xanewok

@Xanewok Xanewok commented Aug 29, 2018

Copy link
Copy Markdown
Contributor

This uses awesome dynamic shields from https://shields.io and queries https://raw.githubusercontent.com/rust-lang-nursery/rust-toolstate/master/_data/latest.json tracked by our awesome rust-toolstate bot.

Rendered

The queries are currently $[2].windows and $[2].linux (jsonpath) respectively, because the data is an array of objects and RLS tool currently happens to be the 3rd one on the list.

@kennytm hopefully this info in README.md shouldn't be useful for too long (because we might want to block nightlies again on RLS fail etc.) but do you think it might be a good idea to change the data format to an object with tool keys { "rls": {...}, "clippy": {...}, ... } to facilitate the quering (e.g. $.rls.linux) or do you think it's not worth the hassle?

Doesn't seem we can dynamically set the color via the dynamic JSON badge, so I hardcoded the color to grey.

@nrc @jonathandturner @alexheretic
do you think this might be useful?

@alexheretic

Copy link
Copy Markdown
Contributor

Cool! Maybe we should link straight to https://rust-lang-nursery.github.io/rust-toolstate/ instead of the github project?

@kennytm

kennytm commented Aug 29, 2018

Copy link
Copy Markdown
Member

@Xanewok

Xanewok commented Aug 29, 2018

Copy link
Copy Markdown
Contributor Author

Definitely! Thank you, pushed commits with respective changes.

@Xanewok

Xanewok commented Aug 29, 2018

Copy link
Copy Markdown
Contributor Author

Seems to be working, now the shields are test-pass thanks to rust-lang/rust#53758 (comment)! 🎉

@nrc
nrc merged commit dc9cedd into rust-lang:master Aug 30, 2018
@nrc

nrc commented Aug 30, 2018

Copy link
Copy Markdown
Member

This is so cool; great idea!

@Xanewok
Xanewok deleted the nightly-shields branch August 30, 2018 08:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants