Repository navigation
Update docs for inline_always + target_feature - #2391
Open
Jamesbarford wants to merge 1 commit into
Open
Jamesbarford wants to merge 1 commit into
Jamesbarford wants to merge 1 commit into
Conversation
rustbot
added
the
S-waiting-on-review
RalfJung
reviewed
Oct 19, 2026
Comment on lines
+317
to
+319
| r[attributes.codegen.target_feature.inline] | ||
| Functions marked with `target_feature` are not inlined into a context that | ||
| does not support the given features. The `#[inline(always)]` attribute may not | ||
| be used with a `target_feature` attribute. | ||
| does not support the given features, a guarantee provided by LLVM since version 23. |
Member
There was a problem hiding this comment.
I think the attributes.codegen.target_feature.inline clause should be removed entirely. What does and does not get inlined is an implementation detail, not a guarantee. The only guarantee we provide is that we're not introducing UB into your code.
Author
There was a problem hiding this comment.
Thanks, I've removed the entire passage now.
Jamesbarford
force-pushed
the
feat/inline_always+target_feature
branch
from
October 19, 2026 11:43
b8e5028 to
d21817a
Compare
traviscross
approved these changes
Oct 21, 2026
traviscross
added
S-waiting-on-stabilization
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 21, 2026
…rget-feature-rust-lang#2, r=nikic,traviscross Feat - `#[inline(always)] + #[target_feature(enable = "....")]` rust-lang#2 This is broadly a resurrection of `#[inline(always)] + #[target_feature(enable = "...")]`. - Applies the `alwaysinline` attribute to the function definition. - `version < LLVM23` downgrades to an `inline` hint. - Remove the check for using [target features + inline always](compiler/rustc_codegen_ssa/src/codegen_attrs.rs) This should now be sound thanks to * llvm/llvm-project#205113 * llvm/llvm-project#209345 Therefore, it should be okay to just allow this combination. But we can also have a period of unstable experimentation if t-lang prefers. Reference PR; rust-lang/reference#2391 r? @RalfJung
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Oct 21, 2026
…#2, r=nikic,traviscross Feat - `#[inline(always)] + #[target_feature(enable = "....")]` #2 This is broadly a resurrection of `#[inline(always)] + #[target_feature(enable = "...")]`. - Applies the `alwaysinline` attribute to the function definition. - `version < LLVM23` downgrades to an `inline` hint. - Remove the check for using [target features + inline always](compiler/rustc_codegen_ssa/src/codegen_attrs.rs) This should now be sound thanks to * llvm/llvm-project#205113 * llvm/llvm-project#209345 Therefore, it should be okay to just allow this combination. But we can also have a period of unstable experimentation if t-lang prefers. Reference PR; rust-lang/reference#2391 r? @RalfJung
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 21, 2026
…rget-feature-rust-lang#2, r=nikic,traviscross Feat - `#[inline(always)] + #[target_feature(enable = "....")]` rust-lang#2 This is broadly a resurrection of `#[inline(always)] + #[target_feature(enable = "...")]`. - Applies the `alwaysinline` attribute to the function definition. - `version < LLVM23` downgrades to an `inline` hint. - Remove the check for using [target features + inline always](compiler/rustc_codegen_ssa/src/codegen_attrs.rs) This should now be sound thanks to * llvm/llvm-project#205113 * llvm/llvm-project#209345 Therefore, it should be okay to just allow this combination. But we can also have a period of unstable experimentation if t-lang prefers. Reference PR; rust-lang/reference#2391 r? @RalfJung
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Oct 21, 2026
…#2, r=nikic,traviscross Feat - `#[inline(always)] + #[target_feature(enable = "....")]` #2 This is broadly a resurrection of `#[inline(always)] + #[target_feature(enable = "...")]`. - Applies the `alwaysinline` attribute to the function definition. - `version < LLVM23` downgrades to an `inline` hint. - Remove the check for using [target features + inline always](compiler/rustc_codegen_ssa/src/codegen_attrs.rs) This should now be sound thanks to * llvm/llvm-project#205113 * llvm/llvm-project#209345 Therefore, it should be okay to just allow this combination. But we can also have a period of unstable experimentation if t-lang prefers. Reference PR; rust-lang/reference#2391 r? @RalfJung
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Oct 21, 2026
…#2, r=nikic,traviscross Feat - `#[inline(always)] + #[target_feature(enable = "....")]` #2 This is broadly a resurrection of `#[inline(always)] + #[target_feature(enable = "...")]`. - Applies the `alwaysinline` attribute to the function definition. - `version < LLVM23` downgrades to an `inline` hint. - Remove the check for using [target features + inline always](compiler/rustc_codegen_ssa/src/codegen_attrs.rs) This should now be sound thanks to * llvm/llvm-project#205113 * llvm/llvm-project#209345 Therefore, it should be okay to just allow this combination. But we can also have a period of unstable experimentation if t-lang prefers. Reference PR; rust-lang/reference#2391 r? @RalfJung
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 21, 2026
…rget-feature-rust-lang#2, r=nikic,traviscross Feat - `#[inline(always)] + #[target_feature(enable = "....")]` rust-lang#2 This is broadly a resurrection of `#[inline(always)] + #[target_feature(enable = "...")]`. - Applies the `alwaysinline` attribute to the function definition. - `version < LLVM23` downgrades to an `inline` hint. - Remove the check for using [target features + inline always](compiler/rustc_codegen_ssa/src/codegen_attrs.rs) This should now be sound thanks to * llvm/llvm-project#205113 * llvm/llvm-project#209345 Therefore, it should be okay to just allow this combination. But we can also have a period of unstable experimentation if t-lang prefers. Reference PR; rust-lang/reference#2391 r? @RalfJung
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Oct 21, 2026
Rollup merge of #162460 - Jamesbarford:feat/inline-always+target-feature-#2, r=nikic,traviscross Feat - `#[inline(always)] + #[target_feature(enable = "....")]` #2 This is broadly a resurrection of `#[inline(always)] + #[target_feature(enable = "...")]`. - Applies the `alwaysinline` attribute to the function definition. - `version < LLVM23` downgrades to an `inline` hint. - Remove the check for using [target features + inline always](compiler/rustc_codegen_ssa/src/codegen_attrs.rs) This should now be sound thanks to * llvm/llvm-project#205113 * llvm/llvm-project#209345 Therefore, it should be okay to just allow this combination. But we can also have a period of unstable experimentation if t-lang prefers. Reference PR; rust-lang/reference#2391 r? @RalfJung
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation updates for the PR allowing
inline_always + target_featurerust-lang/rust#162460