Skip to content

Further cases where lone underscore isn't covered #2020

Closed
#2049
#2021
Closed
Further cases where lone underscore isn't covered#2020
#2049
#2021
Labels
A-proc-macroArea: proc-macros

Description

@mattheww
mattheww
opened on Sep 28, 2025

The Token production in lex.token.syntax is missing an entry for lone _ (which isn't included in IDENTIFIER_OR_KEYWORD).

Similarly the lists in macro.proc.token.macro_rules and macro.proc.token.tree are missing lone underscore, because the Reference doesn't consider "identifier" to include lone uderscore.

Activity

  1. ehuss
    added a commit that references this issue on Sep 29, 2025

    Clarify proc-macro token tree

    816158a

  2. ehuss commented on Sep 29, 2025

    @ehuss
    ehuss
    on Sep 29, 2025
    Contributor

    The Token rule includes PUNCTUATION which includes _. Does that cover what you are looking for in lex.token.syntax?

    As for the proc-macro sections, I have opened #2021 to try to clarify that.

  3. ehuss
    added
    A-proc-macroArea: proc-macros
    on Sep 29, 2025

  4. mattheww commented on Oct 1, 2025

    @mattheww
    mattheww
    on Oct 1, 2025
    ContributorAuthor

    Ah yes, Token is correct as it stands.

  5. ehuss
    added a commit that references this issue on Oct 12, 2025

    Change underscore to be a keyword

    3749e6d
  6. traviscross
    added a commit that references this issue on Oct 22, 2025

    Change underscore to be a keyword

    295dab6
  7. traviscross
    closed this as completedin #2049on Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-proc-macroArea: proc-macros

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions