Skip to content

ctest: allow variadics to be tested. - #5385

Merged
tgross35 merged 1 commit into
rust-lang:mainfrom
mbyx:ctest-support-variadics
Aug 9, 2026
Merged

tgross35 merged 1 commit into
rust-lang:mainfrom
mbyx:ctest-support-variadics

Conversation

@mbyx

@mbyx mbyx commented Aug 7, 2026 •

Copy link
Copy Markdown
Contributor

Description

Removes the check for variadics and adds support for translating variadic types between C and Rust.

While not used currently, might be useful down the line, especially if we ever decide to stop using void pointers for foreign function tests.

Closes #4367

Checklist

  • Relevant tests in libc-test/semver have been updated
  • Commit messages permalink to headers for added or changed API
  • Placeholder or unstable values like *LAST or *MAX have the standard
    doc comment
  • Tested locally (cargo test -p libc-test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot label +stable-nominated

@rustbot rustbot added ctest Issues relating to the ctest crate S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Aug 7, 2026
@JohnTitor
JohnTitor force-pushed the ctest-support-variadics branch from ad35c06 to 2d467a2 Compare August 8, 2026 21:16
@rustbot

rustbot commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@tgross35 tgross35 left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you

View changes since this review

@tgross35
tgross35 added this pull request to the merge queue Aug 9, 2026
Merged via the queue into rust-lang:main with commit a001465 Aug 9, 2026
57 checks passed
@tgross35 tgross35 added stable-unneeded This PR is applied to main but already exists on libc-0.2 and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ctest Issues relating to the ctest crate stable-unneeded This PR is applied to main but already exists on libc-0.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ctest: support variadics in function pointers

3 participants