Breaking change in v0.2.145 for MUSL's open64 #3264

Activity

1. newpavlov

   added

   C-bugCategory: bugCategory: bug

   on Jun 5, 2023
2. bossmc commented on Jun 5, 2023

   

   bossmc

   on Jun 5, 2023

   Contributor

   More actions

   Good spot, and yes indeed that's an unintended change - the whole point of that module is to back-fill a non-breaking API. Unfortunately, we can't shim variadic functions since they're unstable (as local functions) rust-lang/rust#44930. If that were merged we could write something like:

   pub unsafe extern "C" fn open64(
       pathname: *const ::c_char,
       flags: ::c_int,
       mode: ...,
   ) -> ::c_int {
       ::open(pathname, flags, mode)
   }
   

   An earlier version of this change re-exported the LFS64 symbols with use foo as foo64 which caused two problems:

   1. The aliased symbols are the original symbols (have the same address for example) which would be a breaking change
   2. use will alias all matching symbols (which is a problem for e.g. stat64 which is a type and a function)

   The latter of these doesn't matter for open/openat since there's no type to conflict with the function name, but the former would still be a concern.

   @JohnTitor @Amanieu - I proposed for now we switch open/openat to be aliased with a use (with a comment to re-visit once c_variadics is stabilized. thoughts?
3. bossmc commented on Jun 5, 2023

   

   bossmc

   on Jun 5, 2023

   Contributor

   More actions

   Oh, there's a 3rd problem with use-aliasing that also doesn't affect open/openat - if the arguments of an LFS64 function are themselves LFS64-ized then a use-aliased function won't accept them when it should. Doesn't change my previous conclusion, just providing completeness.
4. Amanieu commented on Jun 5, 2023

   

   Amanieu

   on Jun 5, 2023

   Member

   More actions

   I agree with changing this to a use, I think this is the best way forward.
5. bors

   added a commit that references this issue on Jun 6, 2023

   Auto merge of #3265 - bossmc:issue-3264-variadic-open(at), r=Amanieu

   ...

   a6c94f4
6. Amanieu commented on Jun 6, 2023

   

   Amanieu

   on Jun 6, 2023

   Member

   More actions

   I've yanked v0.2.145 for now since it is causing widespread breakage.

   👍React with 👍3Reacted by Fabio A. Correa, l and Frank Elsinga
7. SimonSapin

   added 2 commits that reference this issue on Jun 6, 2023

   Downgrade libc crate from yanked version

   ...

   324b526

   Upgrade libc crate from yanked version (#3222)

   ...

   a5257f6
8. link2xt

   added 3 commits that reference this issue on Jun 6, 2023

   fix: update from yanked `libc` 0.2.145 to 0.2.146

   ...

   bfe6116

   fix: update from yanked `libc` 0.2.145 to 0.2.146

   ...

   6165a11

   fix: update from yanked `libc` 0.2.145 to 0.2.146

   ...

   91bf87f
9. newpavlov commented on Aug 15, 2023

   

   newpavlov

   on Aug 15, 2023

   ContributorAuthor

   More actions

   I think this issue can be closed now?

   👍React with 👍1Reacted by Yuki Okushi
10. JohnTitor

    closed this as completedon Aug 15, 2023