Synchronize TrplNote name - #4605
Merged
Merged
Conversation
This changes the name of the `TrplNote` mdbook preprocessor so that it matches the name used in `book.toml`. The reason this needs to be in sync is that in upstream we use `MDBook::with_preprocessor` to replace the preprocessor, but unfortunately it grabs the name from the preprocessor itself. If these are out of sync, it ends up not being able to replace the old preprocessor config. The API in mdbook should probably be better to make it easier to manage the config. For now, this is probably the easiest fix.
carols10cents
approved these changes
Dec 12, 2025
carols10cents
left a comment
carols10cents
left a comment
Member
There was a problem hiding this comment.
Seems fine to me! Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the name of the
TrplNotemdbook preprocessor so that it matches the name used inbook.toml. The reason this needs to be in sync is that in upstream we useMDBook::with_preprocessorto replace the preprocessor, but unfortunately it grabs the name from the preprocessor itself. If these are out of sync, it ends up not being able to replace the old preprocessor config. The API in mdbook should probably be better to make it easier to manage the config. For now, this is probably the easiest fix.