Make report mod public - #56
Conversation
|
Hey there! Sorry it took so long to get to this. So generally I'm not opposed to this. Especially because making Making this mod pub would go a good way towards allowing this. But I'm wondering if there's a nicer way to achieve that goal and if you'd be interested in collaborating to this effort. Anyway, if we end up just making this module public there needs to be documentation for the newly exposed functions. I defer further opinions on this matter to @killercup and @yoshuawuyts 👋 |
|
I have no strong opinions here; happy to defer to your judgement @spacekookie! |
|
Hi! Now I have to apoligise for the long delay. I really like the approach of trying to find a more generic solution to the problem of working with reports. I'd definitely be happy to help out with this, whether it's by adding the missing docs or a different approach if you have something in mind. :) |
spacekookie
left a comment
There was a problem hiding this comment.
Hey @passy, I've started doing some work on v2.0.0 of this crate and would like to merge your changes.
But CI is currently failing. Could you make sure that all items from the report module are properly documented :)
|
@spacekookie Amazing! I added some docstrings. Can you let me know if this looks good to you? I'm happy to expand or change things. |
spacekookie
left a comment
There was a problem hiding this comment.
Excellent, looks good to me :)
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [j178/prek-action](https://redirect.github.com/j178/prek-action) | action | major | `v1` → `v2` | --- ### Release Notes <details> <summary>j178/prek-action (j178/prek-action)</summary> ### [`v2`](https://redirect.github.com/j178/prek-action/compare/v1...v2) [Compare Source](https://redirect.github.com/j178/prek-action/compare/v1...v2) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/epage/_rust). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjQzLjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Choose one: 🙋 feature
Checklist
Context
Hi! 👋 I was wondering if you'd be opposed to the idea of exposing the
reportmod as public. It is pretty useful on its own and I intend to use theReportstruct directly instead of printing the result.No worries if you don't want to increase the API surface, though. :)
Semver Changes
It changes the public interface, but in a backwards-compatible way. So minor bump should be fine.