Repository navigation
feat: add cross-platform tests and docs for finch events filter flags - #1828
Open
Roslaan001 wants to merge 1 commit into
Open
Roslaan001 wants to merge 1 commit into
Roslaan001 wants to merge 1 commit into
Conversation
Signed-off-by: Abdulsomad Olayiwola Abdulwahab <abdulsomad005@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #1660
Description of changes:
Finch delegates
eventscommands directly to nerdctl. With upstream nerdctl (containerd/nerdctl#4999) adding support for--since,--until, andlabel=filters:--since,until, and--filterflags are cleanly forwarded to the runner.docs/cmd/finch_events.mdto document the-f, --filter,--since, and--untiloptions.Testing done:
make test-unit(61% coverage, meeting the 60% threshold).GOOS=darwin) and Windows (GOOS=windows).[✓] I've reviewed the guidance in CONTRIBUTING.md
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.