Skip to content

Add overloads for math operation with rhs being BigDecimal - #1053

Merged
pocke merged 2 commits into
ruby:masterfrom
piotaixr:feature/bigdecimal-operations
Jul 14, 2022
Merged

pocke merged 2 commits into
ruby:masterfrom
piotaixr:feature/bigdecimal-operations

Conversation

@piotaixr

@piotaixr piotaixr commented Jul 1, 2022

Copy link
Copy Markdown
Contributor

Closes #1052

@pocke

pocke commented Jul 12, 2022

Copy link
Copy Markdown
Member

Could you avoid mixing cosmetic changes? It makes reviewing a bit harder, and the changed format in .rbs files is a different style from other .rbs files in this repository. So could you revert the cosmetic changes and only leave the core changes?

@piotaixr

Copy link
Copy Markdown
Contributor Author

Oh! Of course. Sorry. Will update the PR ASAP.
Asking rubymine to format becomes muscle memory at this point :-)

@piotaixr
piotaixr force-pushed the feature/bigdecimal-operations branch from 8020658 to 51da34f Compare July 12, 2022 11:08
@piotaixr

Copy link
Copy Markdown
Contributor Author

Updated!

@pocke pocke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pocke
pocke merged commit 3d32cfb into ruby:master Jul 14, 2022
ksss added a commit to ksss/gem_rbs_collection that referenced this pull request Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mathematical operations don't play well with BigDecimal

2 participants