Conversation
The wire parser kept the address as hex bytes, so to_text() printed a Python bytes literal, from_text() rejected every such item, and the 127-octet limit was checked against the hex string.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an APL item whose address family is not 1 or 2, the wire parser keeps the address as hex bytes, so
to_text()prints3:b'e0'/4.from_text()rejects that and also3:e0/4, because the constructor wants bytes, not str. The 127-octet limit was also checked against the hex string, so a wire address of 64-127 octets raisedFormError: too long.The constructor now takes the hex address as text (up to 254 characters, checked with
unhexlify), and__str__prints it without the bytes wrapper. Families 1 and 2 are unchanged.The new test parses wire data with a 2-octet and a 64-octet address, checks that the text parses back to the same wire, and rejects odd-length hex. ruff, black and the full test suite (3.10) pass.
Written with AI assistance (Claude); I have reviewed the change.