Rename the second test_af_inferred_from_where so the IPv4 case runs - #1304
Merged
rthalley merged 1 commit intoSep 27, 2026
Merged
Conversation
The IPv6 case reused the IPv4 case's name, so only one of the two ran. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011M5uTyCU4WcNTsPvGrErDo
Owner
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DestinationAndSourceTestsdefinestest_af_inferred_from_wheretwice, on consecutive methods. Python keeps the later one, so only the IPv6 case runs:So inferring
AF_INETfrom an IPv4wherehas no test.Renaming the second to
test_v6_af_inferred_from_where, matching thetest_v6_*names already in the file, puts the IPv4 case back.DestinationAndSourceTestsgoes from 8 to 9 passing.🤖 Generated with Claude Code
https://claude.ai/code/session_011M5uTyCU4WcNTsPvGrErDo