Repository navigation
Revert to pre-Bootstrap 5 nav bs3compat shimming - #336
Merged
Merged
Conversation
schloerke
approved these changes
Jun 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #304, I changed the overall approach to shimming Bootstrap's
$.fn.tabjQuery plugin (I wanted to move away from assuming that it exists), but that approach won't work when tabs are shown programmatically (e.g.,shinycoreci-apps/apps/213-tab-panels).This reverts it to use the same
.noConflict()approach we were using before in a way that works for Bootstrap 5. Originally, I thought that this approach wasn't going to work at all because Bootstrap 5 doesn't register this plugin until the DOM is ready, but now that we execute this code after the DOM is ready, this approach seems to work fine.