Skip to content

Revert "no mo .rda file! (#294)" - #295

Merged
cpsievert merged 1 commit into
masterfrom
revert-dput
Mar 30, 2021
Merged

cpsievert merged 1 commit into
masterfrom
revert-dput

Conversation

@cpsievert

Copy link
Copy Markdown
Collaborator

Reverts #294 since it increases the built tarball from about 4.1 Mb to 5.1 Mb

@cpsievert
cpsievert merged commit a193910 into master Mar 30, 2021
@cpsievert
cpsievert deleted the revert-dput branch March 30, 2021 22:06
@wch

wch commented Mar 30, 2021

Copy link
Copy Markdown
Collaborator

FWIW, I see built sizes of 4263141 bytes for the .R version, and 4236505 for the .rda version.

This is with the .R file:

$ cd bslib && git checkout aa77ed7 && cd .. && R CMD build bslib && ls -l bslib_0.2.4.9002.tar.gz
HEAD is now at aa77ed7  Add a font_scale argument to bs_theme() for a cross-version scalar multiplier of the base font size (#288)
....

-rw-r--r--  1 winston  staff  4263141 Mar 30 18:34 bslib_0.2.4.9002.tar.gz

And with the .rda file:

$ cd bslib && git checkout a193910 && cd .. && R CMD build bslib && ls -l bslib_0.2.4.9002.tar.gz
HEAD is now at a193910 Revert "no mo .rda file! (#294)" (#295)
....

-rw-r--r--  1 winston  staff  4236505 Mar 30 18:33 bslib_0.2.4.9002.tar.gz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants