Allow journald package to build on Windows - #798
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #478. Follows the build-constraint removal proposed in #479, which was closed without merging.
The pinned go-systemd dependency already provides Windows stubs, but the
!windowsconstraint excludedNewJournalDWriterwhen Windows applications imported this package. Remove that constraint and add a Windows regression for the unavailable-journal error and zero bytes written.This enables compilation on Windows. Writing still returns the dependency's error because journald is unavailable there. No dependencies or existing writer logic change.
Validation on Windows/amd64:
go test -race -bench . -benchmem ./...with default benchmark durations andgo test -tags binary_log -race ./....go vet ./...pass. A separate consumer verifies public-package imports, input preservation and logger error propagation in both modes.AI-assisted implementation with independent agent review of the final source and test evidence before submission.