docs: fix dead bench.zerolog.io link in README benchmarks section - #795
Open
CAOShurong wants to merge 1 commit into
Open
CAOShurong wants to merge 1 commit into
CAOShurong wants to merge 1 commit into
Conversation
The Benchmarks section linked to http://bench.zerolog.io/, which no longer resolves (NXDOMAIN on public resolvers). Point the logbench reference at the rs/logbench repository instead.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Benchmarks section of the README links to
http://bench.zerolog.io/, which no longer resolves. Both Cloudflare (1.1.1.1) and Google public DNS return NXDOMAIN for that hostname, so the link is dead for every reader.The reference points at logbench — the benchmark suite lives in the
rs/logbenchrepository (last push 2023-08). This PR repoints the link to https://github.com/rs/logbench so the "more comprehensive and up-to-date benchmarks" pointer works again.Verification
bench.zerolog.io→ Status 3 (NXDOMAIN) via both https://1.1.1.1/dns-query and https://dns.google/resolve*.md, non-test.go): 31 unique URLs live-checked, this was the only non-200go build ./...andgo vet ./...cleanAI disclosure
This fix was identified and prepared with AI assistance under human direction and review by @CAOShurong.