chore: Isolate pkgerrors and drop pkg/errors from main module - #793
chore: Isolate pkgerrors and drop pkg/errors from main module#793aziret wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
why adding this extra file path level?
There was a problem hiding this comment.
Usually external packages are located in /pkg
There was a problem hiding this comment.
The main part of the library is no longer dependant on github.com/pkg/errors
Only users of package pkgerrors will have this transitive dependency on github.com/pkg/errors
There was a problem hiding this comment.
Yes, I understand that part. I’m just wondering why we couldn’t add the go.mod and go.sum files to the package's current location. I couldn't find any convention recommending a pkg directory for this use case.
There was a problem hiding this comment.
I'm just used to moving external packages into /pkg and automatically did this 😄
Reverted my changes back and added module in pkgerrors
1597f02 to
9654f14
Compare
aziret
changed the title
2 participants
This PR removes github.com/pkg/errors as a dependency from the main part of the library and extracts dependency on github.com/pkg/errors to an external pkg
This PR also tries to address the issue 470 from the main repo