Repository navigation
Use new_line after path_meta doc comments - #649
Merged
Merged
Conversation
The doc comment lines written for path_meta always ended with a hardcoded '\n', so with e.g. `new_line: "\r\n"` the output mixed CRLF and LF line endings. Write config.new_line instead.
Member
|
Thanks @LuisFigueroaG! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The doc comments written for
PrettyConfig::path_metaend each line with a hardcoded'\n'instead ofconfig.new_line, so withnew_line("\r\n")the output mixes line endings:Everything else in the pretty serializer already uses
new_line, so this just writesconfig.new_linethere too. The new test intests/544_path_meta.rsfails on master and passes with the fix.cargo testpasses with default features,--no-default-features,integer128,indexmapand--all-features.cargo +1.64.0 clippy -- -D warningsis clean for the same feature sets with the minimal-versions lockfile, the full suite also passes on 1.64.0, andcargo fmt --checkis clean.CHANGELOG.md