Repository navigation
fix(css): inline ?inline CSS imported from dependencies - #1109
Merged
Merged
Conversation
✅ Deploy Preview for tsdown-main ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tsdown
create-tsdown
@tsdown/css
@tsdown/exe
tsdown-migrate
commit: |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The dependency stylesheet inlining change has no active review issues.
No open issues 🎉
What changed in this PR
Fixes dependency stylesheet imports using ?inline so tsdown embeds their contents as strings rather than leaving external imports, addressing #959.
Changes:
- Bypasses automatic externalization for inline CSS while preserving explicit
deps.neverBundlepatterns. - Preserves the query during CSS resolution and normalizes resolved inline IDs.
- Adds a dependency-import regression test and expected output snapshot.
| File | Description |
|---|---|
| tests/css.test.ts | Tests that dependency CSS is embedded without an external import. |
| tests/__snapshots__/css/handle-css-inline-from-dependencies.snap.md | Records the expected embedded stylesheet output. |
| src/features/deps.ts | Exempts inline stylesheets from automatic externalization. |
| packages/css/src/plugin.ts | Keeps the query during resolution and normalizes the inline ID. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI usage
Description
Importing CSS from a dependency with
?inline(e.g.import css from 'jodit/es2021/jodit.css?inline') left the import external instead of embedding the stylesheet as a string. Two things caused it:DepsPluginexternalized it like any other import of a dependency.?inlineCSS is now skipped by the automatic externalization, since it has to be embedded.this.resolve, soDepsPluginsaw a plainpkg/style.css. It now resolves the full id and normalizes the result to<path>?inline.Explicit
deps.neverBundlepatterns still keep the import external.Linked Issues
Closes #959
Additional context
Since the dependency's CSS is now bundled, projects that set
deps.onlyBundlewithout listing that package will get the "not included indeps.onlyBundle" error for it.