Repository navigation
Conversation
✅ Deploy Preview for tsdown-main ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tsdown
create-tsdown
@tsdown/css
@tsdown/exe
tsdown-migrate
commit: |
1 of 3 tasks
sxzz
force-pushed
the
main
branch
3 times, most recently
from
November 6, 2026 09:51
ef50c5b to
1309e6d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI usage
Description
With
css.splitting: false,CssPostPluginpushed each chunk's CSS fromrenderChunk, sostyle.cssfollowed render order. When a module that imports CSS is shared by several entries, it gets its own chunk, and that chunk's CSS was appended after the entry's own CSS even though the entry imports it first.This PR stores each chunk's CSS under its preliminary file name in
renderChunk, then merges ingenerateBundleby walking the entry chunks the way Vite does forcssCodeSplit: false: a chunk's static imports come first, then the chunk itself, and dynamically imported chunks are added last.Two tests are added to
tests/css.test.ts, the repro from the issue and a case with a dynamic import. Both fail onmainand pass with this change.pnpm test run,pnpm lintandpnpm typecheckall pass.Linked Issues
fixes #1086
Additional context
The
splitting: truepath is unchanged.