fix(css): inline ?inline CSS imported from dependencies (#1109)

Co-authored-by: Kevin Bot <gh-bot@sxzz.moe>

Author: sxzz

packages/css/src/plugin.ts

@@ -90,12 +90,11 @@ export function CssPlugin(
     resolveId: {
       filter: { id: RE_CSS_INLINE },
       async handler(source, ...args) {
-        const cleanSource = getCleanId(source)
-        const resolved = await this.resolve(cleanSource, ...args)
+        const resolved = await this.resolve(source, ...args)
         if (resolved) {
           return {
             ...resolved,
-            id: `${resolved.id}?inline`,
+            id: `${getCleanId(resolved.id)}?inline`,
           }
         }
       },

src/features/deps.ts

@@ -30,6 +30,11 @@ const debug = createDebug('tsdown:deps')
 const RE_PACKAGE_SPECIFIER =
   /^(?:@[a-z0-9-][a-z0-9-._]*\/)?[a-z0-9-][a-z0-9-._]*(?:\/|$)/
 
+/**
+ * `?inline` CSS is embedded as a string, so it can't stay an external import.
+ */
+const RE_CSS_INLINE = /\.(?:css|less|sass|scss|styl|stylus)\?(?:.*&)?inline\b/
+
 type ResolveFn = () => Promise<ResolvedId | null>
 
 export type NoExternalFn = (
@@ -363,6 +368,7 @@ export function DepsPlugin(
     if (alwaysBundle?.(id, importer)) {
       return 'no-external'
     }
+    if (RE_CSS_INLINE.test(id)) return false
 
     // `neverBundle: true`: imports that follow npm package naming
     // conventions are externalized as written, without resolving them

tests/__snapshots__/css/handle-css-inline-from-dependencies.snap.md

@@ -0,0 +1,8 @@
+## index.mjs
+
+```mjs
+// index.ts
+console.log(".lib {\n  color: red;\n}\n");
+export {};
+
+```

tests/css.test.ts

@@ -423,6 +423,20 @@ describe('css', () => {
     expect(fileMap['index.mjs']).toContain('color')
   })
 
+  test('handle .css?inline from dependencies', async (context) => {
+    const { fileMap } = await testBuild({
+      context,
+      files: {
+        'index.ts': `import css from 'my-lib/style.css?inline'; console.log(css);`,
+        'package.json': JSON.stringify({ dependencies: { 'my-lib': '*' } }),
+        'node_modules/my-lib/style.css': `.lib { color: red; }`,
+        'node_modules/my-lib/package.json': JSON.stringify({ name: 'my-lib' }),
+      },
+    })
+    expect(fileMap['index.mjs']).not.toContain('import ')
+    expect(fileMap['index.mjs']).toContain('.lib')
+  })
+
   test('handle .scss?inline', async (context) => {
     const { fileMap, outputFiles } = await testBuild({
       context,