Repository navigation
Exception message override log message #631
Description
Hi there.
try {
throw new \RuntimeException('Not yet implemented.');
} catch (\Throwable $exception) {
$this->logger->error('User could not be registered.', [
'exception' => $exception,
]);
}The above Rollbar logged event message is : Not yet implemented.
It should be User could not be registered.
Metadata
Metadata
Assignees
Labels
No labels
Activity
danielmorell commentedon Oct 13, 2023
Hey Thomas, thank you for reporting this!
I took a look at the implementation and
User could not be registered.is being sent as thedescriptionif aThrowableis provided in the'exception'context. I agree this is probably backwards of the way I would have expected it given your code example above.Given there are two messages associated with the error, we have three options (at least that I can think of):
Not yet implemented.as the message andUser could not be registered.as the description.User could not be registered.as the message andNot yet implemented.as the description.User could not be registered. (Not yet implemented.).I think I lean toward option 3. What do you think?
armetiz commentedon Oct 16, 2023
Hi @danielmorell ,
I think option 2. is the best one! This seems obvious to me because it respects developper intention's.
On the above example, you can see the exception line, but in real application errors are thrown in deeper code. When receiving Rollbar alert, developpers knows about theirs codes, but if message is related to a librairy exception.. It's really hard to understand on first sight.
Option 1 is inappropriate.
Option 3 : this is not a bad idea
Fixed #631 Log message in description
Fixed #631 Set log message as primary
Merge pull request #632 from rollbar/fixed/issue-631-message-in-descr…