Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1993.
Open Browserpasses theurlargument straight to the driver, so passing a Robot FrameworkSecret(as in the issue example) callsdriver.get()with theSecretobject instead of the actual URL.Input TextandInput Passwordalready unwrapSecretvalues; this does the same forurl.The
urlargument is now typedstr | Secret | None, the value is unwrapped before it reaches the driver, and the log messages keep the masked<secret>representation so the value is not written to logs.How checked:
python utest/run.py→ 257 passed, 4 skipped. The new unit testtest_open_browser_with_secret_urlfails on master withInstead got: get(Secret(value=<secret>))and passes with the fix.This covers the
urlargument only. Other keywords taking string arguments may still not acceptSecret; I am happy to extend the scope if you prefer a broader change.