You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Implemented feature using dictionary as parameter/return value for set_window_size/get_window_size (See change here). I am wandering if this should be implemented instead as two parameters or a list of two values so it will not require the Collections library. I am sure having it as a dictionary, thus requiring the Collections library, will trip someone up.
The method you are wrapping takes width and height as separate, required arguments. I think the keyword should be the same except hide the windowHandle argument.
@ombre42 I've added some keyworddocumentation with an example. Do you think this is clear? If not, do you have any suggestions for explaining the usage of these keywords.
The documentation is clear. Here's my thoughts (you asked!).
For Set Window Size, the argument names are in single quotes instead of back quotes.
Here's two alternatives to consider:
Sets the width and height of the current window.
Sets the width and height of the current window to the specified values.
Example for Get Window Size could be just: | ${width} | ${height}= | Get Window Size |. The extra code adds clarity to Set Window Size, but not to Get Window Size.
Both examples use the values for SVGA (also the values in the Selenium doc), but the values for height and width are swapped.
I think it is odd Se returns a dict instead of a tuple. Are they going to add depth in the future? :P
Activity
emanlove commentedon Mar 18, 2013
Implemented feature using dictionary as parameter/return value for set_window_size/get_window_size (See change here). I am wandering if this should be implemented instead as two parameters or a list of two values so it will not require the Collections library. I am sure having it as a dictionary, thus requiring the Collections library, will trip someone up.
ombre42 commentedon Mar 18, 2013
The method you are wrapping takes width and height as separate, required arguments. I think the keyword should be the same except hide the windowHandle argument.
emanlove commentedon Mar 18, 2013
@ombre42 Agreed. Thanks for the feedback.
emanlove commentedon Mar 20, 2013
@ombre42 I've added some keyword documentation with an example. Do you think this is clear? If not, do you have any suggestions for explaining the usage of these keywords.
ombre42 commentedon Mar 21, 2013
The documentation is clear. Here's my thoughts (you asked!).
For Set Window Size, the argument names are in single quotes instead of back quotes.
Here's two alternatives to consider:
Sets the
widthandheightof the current window.Sets the
widthandheightof the current window to the specified values.Example for Get Window Size could be just: | ${width} | ${height}= | Get Window Size |. The extra code adds clarity to Set Window Size, but not to Get Window Size.
Both examples use the values for SVGA (also the values in the Selenium doc), but the values for height and width are swapped.
I think it is odd Se returns a dict instead of a tuple. Are they going to add depth in the future? :P
ombre42 commentedon Aug 29, 2014
was in 1.4 release and left open