Fix IndexError in get_current_energy when energy list is empty - #689
Merged
Conversation
WG4 thermostats always report an empty energy list, and WG5 thermostats without a building id do too. get_current_energy() only guarded against None, so an empty list raised IndexError and crashed consumers such as the Home Assistant sensor platform. Treat an empty list like None and return 0.0. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Eer1ZnSZ8sz5oh8pq3AQT2
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #689 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 522 522
Branches 67 67
=========================================
Hits 522 522 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
robbinjanssen
added
the
bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WG4 thermostats always report an empty energy list, and WG5 thermostats without a building id do too. get_current_energy() only guarded against None, so an empty list raised IndexError and crashed consumers such as the Home Assistant sensor platform. Treat an empty list like None and return 0.0.