Repository navigation
Allow SQL backends to use a custom migrations table - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applications embedding go-workflows within their primary application may want to share the main application database with go-workflows. If they use go-migrate, today they will collide with the schema migrations table. Provide an option in go-workflows to specify which table should be used to avoid the conflict.
WithMigrationsTablefor the PostgreSQL and SQLite backends.schema_migrationstable.Tests
go build -v ./...go test -short -timeout 120s -race -count 1 -v ./...make lintgo test -timeout 180s -race -count 1 -v ./backend/postgresgo test -timeout 180s -race -count 1 -v ./backend/redisgo test -timeout 180s -race -count 1 -v ./backend/sqlitego test -timeout 300s -race -count 1 -v ./...Refs rmorlok/authproxy#539