Remove use of filepath for interacting with embedded migration files

[brandur]

This one is in pursuit of resolving #482 in which migrations can't
currently run on Windows.

As @bgentry points out regarding the embed package [1], where forward
slashes are used for all files regardless of underlying operation system:

The patterns are interpreted relative to the package directory
containing the source file. The path separator is a forward slash, even
on Windows systems.

But filepath uses OS-specific separators, making commingling use of
these two packages not advisable:

The filepath package uses either forward slashes or backslashes,
depending on the operating system. To process paths such as URLs that
always use forward slashes regardless of the operating system, see the
path package.

Here, remove use of filepath for migrations by using the IsDir
function of a file entry instead, which also turns out to be much
cleaner anyway.

I don't have a Windows system to test on, but this seems like a pretty
likely fix. A Windows-specific job to test the CLI is in progress as
part of #483, which would help prevent future regressions.

Fixes #482.

[1] https://pkg.go.dev/embed#hdr-Directives

[bgentry]

I just set up Windows CI for the CLI in #483, which reveals the exact issue this PR is supposed to fix. Let's merge that and rebase this one on top of it to confirm the fix?

[bgentry]

Unfortunately this does not appear to resolve the issue. I rebased my PR #483 on this one and did a single run, and a similar panic happened: https://github.com/riverqueue/river/actions/runs/10172817143/job/28135934181?pr=483

However, with the CI in that branch we can at least reproduce this somewhat easily. We can merge that and then you can push a branch with some debug output to help track this down. Not ideal, but neither is finding a real Windows machine to test on 😉

[brandur]

@bgentry So I tried this against your Window job, and it's a little unintuitive, but it actually does work. The problem is that along with this change you also need to uncomment the replace directives in cmd/river/go.mod so that the CLI there pulls in the version of rivermigrate that's on this branch (otherwise it's using the latest tagged version).

As we're sending out this fix we'll need to make sure to cut a new CLI release with bumped versions of the other River packages.

[bgentry]

@brandur sweet! This will just need a rebase to get the updated branch protection rules.

[brandur]

TY. The Windows build is still failing, but we should see it pass as I do the second phase of a new release.