Use TestOnly property in example tests - #440
Merged
Merged
Conversation
I was looking into what was making the example tests so slow (some like the periodic job enqueuer one often take 3 seconds to run), and it turns out that the lion's share of it is from from service start up jitter. Example tests aren't in the main `river` package (they're in `river_test`) so they didn't previously have a way of interacting with the client in such a way as to disable stagger. Luckily, we do have a way now. Take advantage of the recently introduced `TestOnly` client property from #414 to make all the examples faster.
brandur
force-pushed
the
brandur-example-test-only
branch
from
July 9, 2024 00:37
4c34aac to
0a6619b
Compare
bgentry
approved these changes
Jul 9, 2024
bgentry
left a comment
bgentry
left a comment
Contributor
There was a problem hiding this comment.
Awesome! Do you think we should add the flag to higher level docs as well? https://riverqueue.com/docs/testing
Contributor
Author
|
Oh yeah, good idea. I'll take that a bit later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking into what was making the example tests so slow (some like
the periodic job enqueuer one often take 3 seconds to run), and it turns
out that the lion's share of it is from from service start up jitter.
Example tests aren't in the main
riverpackage (they're inriver_test) so they didn't previously have a way of interacting withthe client in such a way as to disable stagger. Luckily, we do have a
way now. Take advantage of the recently introduced
TestOnlyclientproperty from #414 to make all the examples faster.