Add transaction-based variants for all queue functions - #402
Merged
Conversation
brandur
force-pushed
the
brandur-queue-tx
branch
from
June 26, 2024 01:51
33beb8f to
ce6e615
Compare
Contributor
Author
|
@bgentry I was trying to write more tests for River UI endpoints, but found that since I was using test transactions, it wasn't possible to test the queue-related stuff because transaction-based functions were missing. Mind taking a look at this one? |
I noticed while trying to write tests for River UI that it wasn't possible to use any of the queue endpoints with a test transaction because unlike functions `Client.Insert` which have a transaction based `InsertTx` variant, queue functions can only work on the main pool. Here, add transaction variants for all queue functions: * `QueueGetTx` * `QueueListTx` * `QueuePauseTx` * `QueueResumeTx`
brandur
force-pushed
the
brandur-queue-tx
branch
from
June 26, 2024 02:29
ce6e615 to
93c7cbd
Compare
Merged
brandur
added a commit
that referenced
this pull request
Jun 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed while trying to write tests for River UI that it wasn't
possible to use any of the queue endpoints with a test transaction
because unlike functions
Client.Insertwhich have a transaction basedInsertTxvariant, queue functions can only work on the main pool.Here, add transaction variants for all queue functions:
QueueGetTxQueueListTxQueuePauseTxQueueResumeTx