Drop lib/pq use in job listing - #337
Merged
Merged
Conversation
I missed this before, but while working on something else I noticed randomly that apparently we use `lib/pq` in the job list module to encode an array of job states. I think it was an oversight to have brought this in as a hard dependency, so here remove the use of `pg.Array` in favor of just using a normal Go slice instead.
brandur
force-pushed
the
brandur-drop-lib-pq
branch
from
May 4, 2024 19:51
fa283f2 to
517a887
Compare
bgentry
approved these changes
May 4, 2024
bgentry
left a comment
bgentry
left a comment
Contributor
There was a problem hiding this comment.
How the heck did this sneak in?? My bad I think …
Contributor
Author
|
Hah, yeah I was surprised to see it too! Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I missed this before, but while working on something else I noticed
randomly that apparently we use
lib/pqin the job list module toencode an array of job states.
I think it was an oversight to have brought this in as a hard
dependency, so here remove the use of
pg.Arrayin favor of just usinga normal Go slice instead.