You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
CommandQueue::referenceListViewModelInstance stores parent VMI handle on listener but registers it under the child handle #95
In src/command_queue.cpp (line 326 in current HEAD on main; same code present in rive-ios 6.19.1's bundled runtime), CommandQueue::referenceListViewModelInstance looks like:
listener->m_handle is set to handle (the parent passed in), but registerListener is keyed on viewHandle (the freshly-allocated child handle that's also the function's return value). The sibling functions in the same file — referenceNestedViewModelInstance, and both instantiateViewModelInstanceNamed overloads — set listener->m_handle = viewHandle so the two sides agree.
Is the divergence here intentional, or should line 326 also use viewHandle? Happy to send a one-line patch if it's the latter.
Activity